]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ALSA: timer: Fix double unlink of active_list
authorTakashi Iwai <tiwai@suse.de>
Wed, 13 Jan 2016 20:35:06 +0000 (21:35 +0100)
committerTakashi Iwai <tiwai@suse.de>
Wed, 13 Jan 2016 20:42:02 +0000 (21:42 +0100)
commitee8413b01045c74340aa13ad5bdf905de32be736
treefcf247cfbbab80ece20ba1ff232765b9944d2ff1
parentc4a359a0049f2e17b012b31e801e96566f6391e5
ALSA: timer: Fix double unlink of active_list

ALSA timer instance object has a couple of linked lists and they are
unlinked unconditionally at snd_timer_stop().  Meanwhile
snd_timer_interrupt() unlinks it, but it calls list_del() which leaves
the element list itself unchanged.  This ends up with unlinking twice,
and it was caught by syzkaller fuzzer.

The fix is to use list_del_init() variant properly there, too.

Reported-by: Dmitry Vyukov <dvyukov@google.com>
Tested-by: Dmitry Vyukov <dvyukov@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/timer.c