]> git.karo-electronics.de Git - linux-beck.git/commit
thermal: hwmon: Properly report critical temperature in sysfs
authorKrzysztof Kozlowski <krzk@kernel.org>
Tue, 22 Nov 2016 17:22:44 +0000 (19:22 +0200)
committerZhang Rui <rui.zhang@intel.com>
Wed, 30 Nov 2016 02:07:13 +0000 (10:07 +0800)
commitf37fabb8643eaf8e3b613333a72f683770c85eca
treeaf1aa01d5d35783a4d69060d1e5b4d60084cecad
parent5184eeb3b016470956de4c89ca9b53c65ef41452
thermal: hwmon: Properly report critical temperature in sysfs

In the critical sysfs entry the thermal hwmon was returning wrong
temperature to the user-space.  It was reporting the temperature of the
first trip point instead of the temperature of critical trip point.

For example:
/sys/class/hwmon/hwmon0/temp1_crit:50000
/sys/class/thermal/thermal_zone0/trip_point_0_temp:50000
/sys/class/thermal/thermal_zone0/trip_point_0_type:active
/sys/class/thermal/thermal_zone0/trip_point_3_temp:120000
/sys/class/thermal/thermal_zone0/trip_point_3_type:critical

Since commit e68b16abd91d ("thermal: add hwmon sysfs I/F") the driver
have been registering a sysfs entry if get_crit_temp() callback was
provided.  However when accessed, it was calling get_trip_temp() instead
of the get_crit_temp().

Fixes: e68b16abd91d ("thermal: add hwmon sysfs I/F")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
drivers/thermal/thermal_hwmon.c