From 01e537f73335339196be3ef2bbfe53c20a6cb200 Mon Sep 17 00:00:00 2001 From: Kuppuswamy Sathyanarayanan Date: Fri, 15 May 2015 16:42:56 -0700 Subject: [PATCH] iio: ltr501: Fix proximity threshold boundary check Currently, proximity sensor boundary check is done inside the switch block but outside the case statement.Since this code will never get executed, moved the check outside the switch case statement. 867 case IIO_PROXIMITY: 868 switch (dir) { // Following line has been moved outside the switch block. 869 if (val > LTR501_PS_THRESH_MASK) 870 return -EINVAL; 871 case IIO_EV_DIR_RISING: Signed-off-by: Kuppuswamy Sathyanarayanan Signed-off-by: Jonathan Cameron --- drivers/iio/light/ltr501.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c index 280eff19b872..64e235281cef 100644 --- a/drivers/iio/light/ltr501.c +++ b/drivers/iio/light/ltr501.c @@ -865,9 +865,9 @@ static int ltr501_write_thresh(struct iio_dev *indio_dev, return -EINVAL; } case IIO_PROXIMITY: - switch (dir) { if (val > LTR501_PS_THRESH_MASK) return -EINVAL; + switch (dir) { case IIO_EV_DIR_RISING: mutex_lock(&data->lock_ps); ret = regmap_bulk_write(data->regmap, -- 2.39.5