From 06f6c8d4010d074c2f163eb0e1d17ad5e5574784 Mon Sep 17 00:00:00 2001 From: Sreya Mittal Date: Fri, 24 Feb 2017 21:30:14 +0530 Subject: [PATCH] staging: speakup: Clean up if tests Put logical continuations on the next line; remove useless parentheses; and line up the tests. Signed-off-by: Sreya Mittal Acked-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman --- drivers/staging/speakup/i18n.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c index 56ce3862a3ea..1a3e34880ac1 100644 --- a/drivers/staging/speakup/i18n.c +++ b/drivers/staging/speakup/i18n.c @@ -411,8 +411,8 @@ static char *next_specifier(char *input) next_percent = strchr(next_percent, '%'); if (next_percent) { /* skip over doubled percent signs */ - while ((next_percent[0] == '%') - && (next_percent[1] == '%')) + while (next_percent[0] == '%' && + next_percent[1] == '%') next_percent += 2; if (*next_percent == '%') found = 1; @@ -549,10 +549,10 @@ ssize_t spk_msg_set(enum msg_index_t index, char *text, size_t length) if (newstr) { memcpy(newstr, text, length); newstr[length] = '\0'; - if ((index >= MSG_FORMATTED_START - && index <= MSG_FORMATTED_END) - && !fmt_validate(speakup_default_msgs[index], - newstr)) { + if (index >= MSG_FORMATTED_START && + index <= MSG_FORMATTED_END && + !fmt_validate(speakup_default_msgs[index], + newstr)) { kfree(newstr); return -EINVAL; } -- 2.39.5