From 0868f35e6c22a632015ac790766627f2bd3d0e69 Mon Sep 17 00:00:00 2001 From: Liu Ying Date: Tue, 29 Oct 2013 12:31:36 +0800 Subject: [PATCH] ENGR00285273-3 IPU dev:Remove unnecessary memset before kfree This patch removes unnecessary memset() before kfree(). Also, it fixes a potential NULL pointer dereference(writing to a freed block of memory). Signed-off-by: Liu Ying --- drivers/mxc/ipu3/ipu_device.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/mxc/ipu3/ipu_device.c b/drivers/mxc/ipu3/ipu_device.c index e20241476424..72a9905d5bea 100644 --- a/drivers/mxc/ipu3/ipu_device.c +++ b/drivers/mxc/ipu3/ipu_device.c @@ -1414,8 +1414,6 @@ static void task_mem_free(struct kref *ref) { struct ipu_task_entry *tsk = container_of(ref, struct ipu_task_entry, refcount); - - memset(tsk, 0, sizeof(*tsk)); kfree(tsk); } @@ -1731,7 +1729,6 @@ err_exit: if (!tsk) continue; kfree(tsk); - memset(tsk, 0, sizeof(*tsk)); } t->state = STATE_ERR; return ret; -- 2.39.5