From 1f08ad02379530e1c970d3d104343b9907b4d1b4 Mon Sep 17 00:00:00 2001 From: Dave Hansen Date: Sat, 16 Apr 2005 15:25:49 -0700 Subject: [PATCH] [PATCH] undo do_readv_writev() behavior change Bugme bug 4326: http://bugme.osdl.org/show_bug.cgi?id=4326 reports: executing the systemcall readv with Bad argument ->len == -1) it gives out error EFAULT instead of EINVAL Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- fs/read_write.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/read_write.c b/fs/read_write.c index 6be4b1a1956b..c4c2bee373ed 100644 --- a/fs/read_write.c +++ b/fs/read_write.c @@ -467,10 +467,10 @@ static ssize_t do_readv_writev(int type, struct file *file, void __user *buf = iov[seg].iov_base; ssize_t len = (ssize_t)iov[seg].iov_len; - if (unlikely(!access_ok(vrfy_dir(type), buf, len))) - goto Efault; if (len < 0) /* size_t not fitting an ssize_t .. */ goto out; + if (unlikely(!access_ok(vrfy_dir(type), buf, len))) + goto Efault; tot_len += len; if ((ssize_t)tot_len < 0) /* maths overflow on the ssize_t */ goto out; -- 2.39.5