From 280c4bc5394d0792db31aee503527b01cda69e73 Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Thu, 7 Feb 2013 12:26:31 +1100 Subject: [PATCH] memory-hotplug-do-not-allocate-pdgat-if-it-was-not-freed-when-offline-fix fix warning when CONFIG_NEED_MULTIPLE_NODES=n Cc: "H. Peter Anvin" Cc: Ingo Molnar Cc: Jiang Liu Cc: Jianguo Wu Cc: KOSAKI Motohiro Cc: Kamezawa Hiroyuki Cc: Lai Jiangshan Cc: Tang Chen Cc: Thomas Gleixner Cc: Wen Congyang Cc: Wu Jianguo Cc: Yasuaki Ishimatsu Cc: Randy Dunlap Signed-off-by: Andrew Morton --- mm/memory_hotplug.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 2bc92267fca7..c806abd78d0e 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1077,7 +1077,8 @@ out: int __ref add_memory(int nid, u64 start, u64 size) { pg_data_t *pgdat = NULL; - int new_pgdat = 0, new_node = 0; + bool new_pgdat; + bool new_node; struct resource *res; int ret; @@ -1088,8 +1089,8 @@ int __ref add_memory(int nid, u64 start, u64 size) if (!res) goto out; - new_pgdat = NODE_DATA(nid) ? 0 : 1; - new_node = node_online(nid) ? 0 : 1; + new_pgdat = (NODE_DATA(nid) == NULL); + new_node = !node_online(nid); if (new_node) { pgdat = hotadd_new_pgdat(nid, start); ret = -ENOMEM; -- 2.39.5