From 2bdf6ea51ce8dcd98f4f394d7203dbace01f5cbc Mon Sep 17 00:00:00 2001 From: Krzysztof Opasiak Date: Wed, 27 Apr 2016 20:00:26 +0200 Subject: [PATCH] usb: usbip: vudc: Fix WARN_ON() usage pattern Fix WARN_ON() macro usage as suggested by Felipe. Instead of using: if (cond) { WARN_ON(1); do_stuff(); } Use a better pattern with WARN_ON() placed in if condition: if (WARN_ON(cond)) do_stuff(); Signed-off-by: Krzysztof Opasiak Signed-off-by: Greg Kroah-Hartman --- drivers/usb/usbip/vudc_dev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c index 43047f4fbca2..0523f2970835 100644 --- a/drivers/usb/usbip/vudc_dev.c +++ b/drivers/usb/usbip/vudc_dev.c @@ -312,10 +312,9 @@ static void vep_free_request(struct usb_ep *_ep, struct usb_request *_req) { struct vrequest *req; - if (!_ep || !_req) { - WARN_ON(1); + if (WARN_ON(!_ep || !_req)) return; - } + req = to_vrequest(_req); kfree(req); } -- 2.39.5