From 2d533cf16bffc579b03f8e376b2f01f09a092aeb Mon Sep 17 00:00:00 2001 From: Vaibhav Hiremath Date: Tue, 21 Jun 2016 23:28:02 +0530 Subject: [PATCH] greybus: ratelimit errors usually seen on unipro_reset It is believed that excessive serial messages from greybus on suspend/resume is leading to watchdog bite. There is still discussion going on whether ratelimiting prints would really fix anything, except it may reduce traffic on serial console and probably bring out real issues in the front. So in order to meet the alpha requirement, we all decided to get ratelimit change "as a TEMP fix" and decide later whether we should revert back once we get proper suspend/resume implementation. Please follow the discussion on Jira card SW-6261. Testing Done: Build tested against ara/main branch. Signed-off-by: Vaibhav Hiremath Reviewed-by: Konstantin Buhchev Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/es2.c | 2 +- drivers/staging/greybus/operation.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/es2.c b/drivers/staging/greybus/es2.c index bdf502493e31..426f83e1fda6 100644 --- a/drivers/staging/greybus/es2.c +++ b/drivers/staging/greybus/es2.c @@ -473,7 +473,7 @@ static int message_send(struct gb_host_device *hd, u16 cport_id, retval = usb_submit_urb(urb, gfp_mask); if (retval) { - dev_err(&udev->dev, "failed to submit out-urb: %d\n", retval); + dev_err_ratelimited(&udev->dev, "failed to submit out-urb: %d\n", retval); spin_lock_irqsave(&es2->cport_out_urb_lock, flags); message->hcpriv = NULL; diff --git a/drivers/staging/greybus/operation.c b/drivers/staging/greybus/operation.c index 659e84b10c7f..136707002b90 100644 --- a/drivers/staging/greybus/operation.c +++ b/drivers/staging/greybus/operation.c @@ -1127,7 +1127,7 @@ int gb_operation_sync_timeout(struct gb_connection *connection, int type, ret = gb_operation_request_send_sync_timeout(operation, timeout); if (ret) { - dev_err(&connection->hd->dev, + dev_err_ratelimited(&connection->hd->dev, "%s: synchronous operation of type 0x%02x failed: %d\n", connection->name, type, ret); } else { -- 2.39.5