From 36f450e8fed193360d833b778ceb92b5b5ac9cc7 Mon Sep 17 00:00:00 2001 From: Hugh Dickins Date: Tue, 26 Jul 2011 20:14:35 +1000 Subject: [PATCH] My load tests on PowerPC freeze within minutes in __slab_free(). I happened to try PPC first, didn't try without this fix on x86. It looks as if the author was interrupted while devising the new cmpxchg_double_slab() version of __slab_free(): its decision to spin_lock_irqsave() depends on several uninitialized fields, and fixing that (by copying page to new) mostly fixes it. But I didn't think about it very much, and this may well not be what the author intends; and I have seen a couple of much rarer freezes in __slab_free() on PPC (not yet on x86) even after applying this. Signed-off-by: Hugh Dickins Cc: Pekka Enberg Cc: Christoph Lameter Signed-off-by: Andrew Morton --- mm/slub.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/slub.c b/mm/slub.c index eb5a8f93338a..119c850b81e3 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2326,6 +2326,7 @@ static void __slab_free(struct kmem_cache *s, struct page *page, return; do { + new = *page; prior = page->freelist; counters = page->counters; set_freepointer(s, object, prior); -- 2.39.5