From 3785b4802ed22201d836d991666b007e07e7acc6 Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Thu, 3 May 2012 15:44:39 +1000 Subject: [PATCH] proc-clean-up-proc-pid-environ-handling-checkpatch-fixes ERROR: "foo* bar" should be "foo *bar" #26: FILE: fs/proc/base.c:680: +static int __mem_open(struct inode* inode, struct file* file, unsigned int mode) ERROR: "foo* bar" should be "foo *bar" #26: FILE: fs/proc/base.c:680: +static int __mem_open(struct inode* inode, struct file* file, unsigned int mode) ERROR: "foo* bar" should be "foo *bar" #43: FILE: fs/proc/base.c:708: +static int mem_open(struct inode* inode, struct file* file) ERROR: "foo* bar" should be "foo *bar" #43: FILE: fs/proc/base.c:708: +static int mem_open(struct inode* inode, struct file* file) ERROR: "foo* bar" should be "foo *bar" #55: FILE: fs/proc/base.c:809: +static int environ_open(struct inode* inode, struct file* file) ERROR: "foo* bar" should be "foo *bar" #55: FILE: fs/proc/base.c:809: +static int environ_open(struct inode* inode, struct file* file) total: 6 errors, 0 warnings, 100 lines checked ./patches/proc-clean-up-proc-pid-environ-handling.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Cong Wang Signed-off-by: Andrew Morton --- fs/proc/base.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/proc/base.c b/fs/proc/base.c index f3c48870909b..a5e480670046 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -677,7 +677,7 @@ static const struct file_operations proc_single_file_operations = { .release = single_release, }; -static int __mem_open(struct inode* inode, struct file* file, unsigned int mode) +static int __mem_open(struct inode *inode, struct file *file, unsigned int mode) { struct task_struct *task = get_proc_task(file->f_path.dentry->d_inode); struct mm_struct *mm; @@ -705,7 +705,7 @@ static int __mem_open(struct inode* inode, struct file* file, unsigned int mode) return 0; } -static int mem_open(struct inode* inode, struct file* file) +static int mem_open(struct inode *inode, struct file *file) { return __mem_open(inode, file, PTRACE_MODE_ATTACH); } @@ -806,7 +806,7 @@ static const struct file_operations proc_mem_operations = { .release = mem_release, }; -static int environ_open(struct inode* inode, struct file* file) +static int environ_open(struct inode *inode, struct file *file) { return __mem_open(inode, file, PTRACE_MODE_READ); } -- 2.39.5