From 3b69a4c9becde783cd89758075780f9d871ba4b6 Mon Sep 17 00:00:00 2001 From: Yang Yingliang Date: Tue, 17 Dec 2013 15:29:16 +0800 Subject: [PATCH] act_police: remove unnecessary null pointer check It already has a NULL pointer check of rtab in qdisc_put_rtab(). Remove the check outside of qdisc_put_rtab(). Signed-off-by: Yang Yingliang Signed-off-by: David S. Miller --- net/sched/act_police.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/sched/act_police.c b/net/sched/act_police.c index 0cc305e7e469..7b23ab07c6cc 100644 --- a/net/sched/act_police.c +++ b/net/sched/act_police.c @@ -261,10 +261,8 @@ override: failure_unlock: spin_unlock_bh(&police->tcf_lock); failure: - if (P_tab) - qdisc_put_rtab(P_tab); - if (R_tab) - qdisc_put_rtab(R_tab); + qdisc_put_rtab(P_tab); + qdisc_put_rtab(R_tab); if (ret == ACT_P_CREATED) kfree(police); return err; -- 2.39.5