From 3bfc8152b2c09d81fb00f4d3990e5dfd59682b96 Mon Sep 17 00:00:00 2001 From: Tom Rini Date: Tue, 12 Apr 2016 15:11:24 -0400 Subject: [PATCH] drivers/power/pmic/pm8916.c: Make usid be uint32_t If get_dev_addr fails it will return FDT_ADDR_T_NONE and: >>> "priv->usid == 4294967295U" is always false regardless of the values of its operands. This occurs as the logical operand of if. Cc: Mateusz Kulikowski Reported-by: Coverity (CID: 143914) Signed-off-by: Tom Rini --- drivers/power/pmic/pm8916.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/pmic/pm8916.c b/drivers/power/pmic/pm8916.c index 9acf5f55f7..d4c7d4adff 100644 --- a/drivers/power/pmic/pm8916.c +++ b/drivers/power/pmic/pm8916.c @@ -18,7 +18,7 @@ DECLARE_GLOBAL_DATA_PTR; #define REG_MASK 0xFF struct pm8916_priv { - uint16_t usid; /* Slave ID on SPMI bus */ + uint32_t usid; /* Slave ID on SPMI bus */ }; static int pm8916_reg_count(struct udevice *dev) -- 2.39.5