From 47222ad33a24f7bb5f21f190ce0bff72edbe7cfe Mon Sep 17 00:00:00 2001 From: Stephen Rothwell Date: Fri, 29 Jul 2011 16:55:11 +1000 Subject: [PATCH] linux/dmaengine.h needs bitmap.h and asm/page.h Presumably caused by some include file no longer being implicitly included. In file included from drivers/dma/iovlock.c:28:0: include/linux/dmaengine.h: In function '__dma_cap_zero': include/linux/dmaengine.h:736:2: error: implicit declaration of function 'bitmap_zero' In file included from include/linux/nodemask.h:95:0, from include/linux/mmzone.h:16, from include/linux/gfp.h:4, from include/linux/mm.h:8, from include/linux/pagemap.h:7, from drivers/dma/iovlock.c:29: include/linux/bitmap.h: At top level: include/linux/bitmap.h:159:20: warning: conflicting types for 'bitmap_zero' include/linux/bitmap.h:159:20: error: static declaration of 'bitmap_zero' follows non-static declaration include/linux/dmaengine.h:736:2: note: previous implicit declaration of 'bitmap_zero' was here PG: In addition to Stephen's find above, I found this variant, needing page.h include/linux/dmaengine.h:684: warning: 'struct page' declared inside parameter list include/linux/dmaengine.h:684: warning: its scope is only this definition or declaration, which is probably not what you want include/linux/dmaengine.h:687: warning: 'struct page' declared inside parameter list Signed-off-by: Stephen Rothwell Signed-off-by: Paul Gortmaker --- include/linux/dmaengine.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h index 8fbf40e0713c..1ceff5ae9d31 100644 --- a/include/linux/dmaengine.h +++ b/include/linux/dmaengine.h @@ -24,6 +24,8 @@ #include #include #include +#include +#include struct scatterlist; -- 2.39.5