From 48786770bf3b3a47bda766ba5f711199e7f24d8f Mon Sep 17 00:00:00 2001 From: Sergey Senozhatsky Date: Wed, 18 Apr 2012 16:44:48 +0100 Subject: [PATCH] kmemleak: do not leak object after tree insertion error In case when tree insertion fails due to already existing object error, pointer to allocated object gets lost because of overwrite with lookup_object() return. Free allocated object before object lookup. Signed-off-by: Sergey Senozhatsky Signed-off-by: Catalin Marinas --- mm/kmemleak.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/kmemleak.c b/mm/kmemleak.c index 45eb6217bf38..5f059935f7bb 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c @@ -578,6 +578,7 @@ static struct kmemleak_object *create_object(unsigned long ptr, size_t size, if (node != &object->tree_node) { kmemleak_stop("Cannot insert 0x%lx into the object search tree " "(already existing)\n", ptr); + kmem_cache_free(object_cache, object); object = lookup_object(ptr, 1); spin_lock(&object->lock); dump_object_info(object); -- 2.39.5