From 53144b419e176e51157f6b9fc651ab9e733cb000 Mon Sep 17 00:00:00 2001 From: Vlad Yasevich Date: Wed, 3 Sep 2008 01:02:19 -0700 Subject: [PATCH] sctp: correct bounds check in sctp_setsockopt_auth_key [ Upstream commit 328fc47ea0bcc27d9afa69c3ad6e52431cadd76c ] The bonds check to prevent buffer overlflow was not exactly right. It still allowed overflow of up to 8 bytes which is sizeof(struct sctp_authkey). Since optlen is already checked against the size of that struct, we are guaranteed not to cause interger overflow either. Signed-off-by: Vlad Yasevich Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/sctp/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index e62aafc320c2..68681fee61a6 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -3054,7 +3054,7 @@ static int sctp_setsockopt_auth_key(struct sock *sk, goto out; } - if (authkey->sca_keylength > optlen) { + if (authkey->sca_keylength > optlen - sizeof(struct sctp_authkey)) { ret = -EINVAL; goto out; } -- 2.39.5