From 554933416ad0be15bbe3a78dd93ea7951a6f254e Mon Sep 17 00:00:00 2001 From: Frederic Weisbecker Date: Wed, 5 Oct 2011 11:43:45 +1100 Subject: [PATCH] cgroups: add res_counter_write_u64() API Extend the resource counter API with a mirror of res_counter_read_u64() to make it handy to update a resource counter value from a cgroup subsystem u64 value file. Signed-off-by: Frederic Weisbecker Acked-by: Paul Menage Cc: Li Zefan Cc: Johannes Weiner Cc: Aditya Kali Cc: Oleg Nesterov Cc: Kay Sievers Cc: Tim Hockin Cc: Tejun Heo Cc: Kirill A. Shutemov Signed-off-by: Andrew Morton --- include/linux/res_counter.h | 2 ++ kernel/res_counter.c | 25 +++++++++++++++++++------ 2 files changed, 21 insertions(+), 6 deletions(-) diff --git a/include/linux/res_counter.h b/include/linux/res_counter.h index c9d625ca659e..1b3fe058fcb1 100644 --- a/include/linux/res_counter.h +++ b/include/linux/res_counter.h @@ -82,6 +82,8 @@ int res_counter_memparse_write_strategy(const char *buf, int res_counter_write(struct res_counter *counter, int member, const char *buffer, write_strategy_fn write_strategy); +void res_counter_write_u64(struct res_counter *counter, int member, u64 val); + /* * the field descriptors. one for each member of res_counter */ diff --git a/kernel/res_counter.c b/kernel/res_counter.c index 34683efa2cce..0faafccbb80e 100644 --- a/kernel/res_counter.c +++ b/kernel/res_counter.c @@ -168,12 +168,26 @@ int res_counter_memparse_write_strategy(const char *buf, return 0; } +void res_counter_write_u64(struct res_counter *counter, int member, u64 val) +{ + unsigned long long *target; + unsigned long flags; + + /* + * We need the lock to protect against concurrent add/dec on 32 bits. + * No need to ifdef it's seldom used. + */ + spin_lock_irqsave(&counter->lock, flags); + target = res_counter_member(counter, member); + *target = val; + spin_unlock_irqrestore(&counter->lock, flags); +} + int res_counter_write(struct res_counter *counter, int member, const char *buf, write_strategy_fn write_strategy) { char *end; - unsigned long flags; - unsigned long long tmp, *val; + unsigned long long tmp; if (write_strategy) { if (write_strategy(buf, &tmp)) @@ -183,9 +197,8 @@ int res_counter_write(struct res_counter *counter, int member, if (*end != '\0') return -EINVAL; } - spin_lock_irqsave(&counter->lock, flags); - val = res_counter_member(counter, member); - *val = tmp; - spin_unlock_irqrestore(&counter->lock, flags); + + res_counter_write_u64(counter, member, tmp); + return 0; } -- 2.39.5