From 55fa328aecb1daf9134278b0eb660502627bf60e Mon Sep 17 00:00:00 2001 From: Devendra Naga Date: Tue, 4 Jun 2013 02:46:20 +0530 Subject: [PATCH] staging: octeon-usb: check return value of platform_device_register_simple the return value is a pointer having an error set. we have to check for IS_ERR and return PTR_ERR when appropriate Cc: Aaro Koskinen Cc: David Daney Signed-off-by: Devendra Naga Signed-off-by: Greg Kroah-Hartman --- drivers/staging/octeon-usb/octeon-hcd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index 987e6a90cbbc..f3a096be2aba 100644 --- a/drivers/staging/octeon-usb/octeon-hcd.c +++ b/drivers/staging/octeon-usb/octeon-hcd.c @@ -23,6 +23,8 @@ #include +#include + //#define DEBUG_CALL(format, ...) printk(format, ##__VA_ARGS__) #define DEBUG_CALL(format, ...) do {} while (0) //#define DEBUG_SUBMIT(format, ...) printk(format, ##__VA_ARGS__) @@ -781,9 +783,9 @@ static int __init octeon_usb_module_init(void) irq_resource.end = irq_resource.start; irq_resource.flags = IORESOURCE_IRQ; pdev = platform_device_register_simple((char*)octeon_usb_driver.name, device, &irq_resource, 1); - if (!pdev) { + if (IS_ERR(pdev)) { DEBUG_FATAL("OcteonUSB: Failed to allocate platform device for USB%d\n", device); - return -ENOMEM; + return PTR_ERR(pdev); } if (device < MAX_USB_PORTS) pdev_glob[device] = pdev; -- 2.39.5