From 574452d71679f4b01a6110fe526b4e8618ec6412 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Wed, 15 Aug 2012 10:49:43 +0300 Subject: [PATCH] hwmon: (adt7410) handle errors from adt7410_update_device() Smatch complains that adt7410_update_device() can return error pointers. Signed-off-by: Dan Carpenter Signed-off-by: Guenter Roeck --- drivers/hwmon/adt7410.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/adt7410.c b/drivers/hwmon/adt7410.c index f8606dff3d1c..030c8d7c33a5 100644 --- a/drivers/hwmon/adt7410.c +++ b/drivers/hwmon/adt7410.c @@ -236,9 +236,14 @@ static ssize_t adt7410_show_t_hyst(struct device *dev, char *buf) { struct sensor_device_attribute *attr = to_sensor_dev_attr(da); - struct adt7410_data *data = adt7410_update_device(dev); + struct adt7410_data *data; int nr = attr->index; - int hyst = (data->hyst & ADT7410_T_HYST_MASK) * 1000; + int hyst; + + data = adt7410_update_device(dev); + if (IS_ERR(data)) + return PTR_ERR(data); + hyst = (data->hyst & ADT7410_T_HYST_MASK) * 1000; /* * hysteresis is stored as a 4 bit offset in the device, convert it -- 2.39.5