From 5ce91a9e854aba900a5bcddcd1c2297d7ff5cd40 Mon Sep 17 00:00:00 2001 From: Vaishali Thakkar Date: Tue, 23 Sep 2014 19:22:41 +0530 Subject: [PATCH] Staging: lustre: Return statement is moved left after removing else This patch fixes following checkpatch.pl warning using coccinelle: WARNING: else is not generally useful after a break or return Semantic patch used for this is as follows: @rule1@ expression e1; @@ if (e1) { ... return ...; } - else{ ... - } @rule2@ expression e2; statement s1; @@ if(e2) { ... return ...; } - else s1 Signed-off-by: Vaishali Thakkar Acked-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman --- drivers/staging/lustre/lustre/ptlrpc/niobuf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/ptlrpc/niobuf.c b/drivers/staging/lustre/lustre/ptlrpc/niobuf.c index 0067e0612ba6..c1e8aa4d5ec4 100644 --- a/drivers/staging/lustre/lustre/ptlrpc/niobuf.c +++ b/drivers/staging/lustre/lustre/ptlrpc/niobuf.c @@ -442,8 +442,7 @@ int ptlrpc_reply(struct ptlrpc_request *req) { if (req->rq_no_reply) return 0; - else - return ptlrpc_send_reply(req, 0); + return ptlrpc_send_reply(req, 0); } EXPORT_SYMBOL(ptlrpc_reply); -- 2.39.5