From 5d2db6e6f6e5b8a749e2ac16ad509770b55d99d4 Mon Sep 17 00:00:00 2001 From: Ed Cashin Date: Thu, 29 Nov 2012 14:19:04 +1100 Subject: [PATCH] aoe: avoid using skb member after dev_queue_xmit After calling dev_queue_xmit it is no longer safe to access the members of the skb. Signed-off-by: Ed Cashin Reported-by: Dan Carpenter Signed-off-by: Andrew Morton --- drivers/block/aoe/aoenet.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/block/aoe/aoenet.c b/drivers/block/aoe/aoenet.c index 3cf068b74b77..24eca2bf9416 100644 --- a/drivers/block/aoe/aoenet.c +++ b/drivers/block/aoe/aoenet.c @@ -55,12 +55,14 @@ static int tx(void) __must_hold(&txlock) { struct sk_buff *skb; + struct net_device *ifp; while ((skb = skb_dequeue(&skbtxq))) { spin_unlock_irq(&txlock); + ifp = skb->dev; if (dev_queue_xmit(skb) == NET_XMIT_DROP && net_ratelimit()) pr_warn("aoe: packet could not be sent on %s. %s\n", - skb->dev ? skb->dev->name : "netif", + ifp ? ifp->name : "netif", "consider increasing tx_queue_len"); spin_lock_irq(&txlock); } -- 2.39.5