From 5e19bfb5fbc1ca130675e1cc395717eb8dee6458 Mon Sep 17 00:00:00 2001 From: Vlastimil Babka Date: Tue, 3 Jun 2014 09:37:10 +1000 Subject: [PATCH] mm-compaction-properly-signal-and-act-upon-lock-and-need_sched-contention-fix-2 Step 1: Change function name and comment between v1 and v2 so that the return value signals the opposite thing. Step 2: Change the call sites to reflect the opposite return value. Step 3: ??? Step 4: Make a complete fool of yourself. Signed-off-by: Vlastimil Babka Reported-by: Kevin Hilman Reported-by: Shawn Guo Tested-by: Shawn Guo Tested-by: Kevin Hilman Tested-by: Stephen Warren Tested-by: Fabio Estevam Acked-by: David Rientjes Cc: Stephen Rothwell Signed-off-by: Andrew Morton --- mm/compaction.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index a525cd47a9d5..51750197db11 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -237,13 +237,13 @@ static inline bool compact_should_abort(struct compact_control *cc) if (need_resched()) { if (cc->mode == MIGRATE_ASYNC) { cc->contended = true; - return false; + return true; } cond_resched(); } - return true; + return false; } /* Returns true if the page is within a block suitable for migration to */ -- 2.39.5