From 5f96fa290e99385ec4da061024ff29b5913b5bbd Mon Sep 17 00:00:00 2001 From: Jan Kara Date: Wed, 20 Feb 2013 13:13:56 +1100 Subject: [PATCH] fs: fix hang with BSD accounting on frozen filesystem When BSD process accounting is enabled and logs information to a filesystem which gets frozen, system easily becomes unusable because each attempt to account process information blocks. Thus e.g. every task gets blocked in exit. It seems better to drop accounting information (which can already happen when filesystem is running out of space) instead of locking system up. So we open the accounting file with O_NONBLOCK. Signed-off-by: Jan Kara Reported-by: Nikola Ciprich Tested-by: Nikola Ciprich Reviewed-by: Dave Chinner Cc: Al Viro Cc: Joel Becker Cc: Mark Fasheh Cc: Marco Stornelli Signed-off-by: Andrew Morton --- kernel/acct.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/acct.c b/kernel/acct.c index e8b1627ab9c7..58a047e6d697 100644 --- a/kernel/acct.c +++ b/kernel/acct.c @@ -201,7 +201,8 @@ static int acct_on(struct filename *pathname) struct bsd_acct_struct *acct = NULL; /* Difference from BSD - they don't do O_APPEND */ - file = file_open_name(pathname, O_WRONLY|O_APPEND|O_LARGEFILE, 0); + file = file_open_name(pathname, + O_WRONLY|O_APPEND|O_LARGEFILE|O_NONBLOCK, 0); if (IS_ERR(file)) return PTR_ERR(file); -- 2.39.5