From 614d73edae68836f7659ee8efec90878e6215fb1 Mon Sep 17 00:00:00 2001 From: Russell King Date: Wed, 27 Jul 2005 23:00:05 +0100 Subject: [PATCH] [ARM SMP] Fix data corruption in test_* bitops If we found that the bit was already in the desired state, we would skip performing the operation, and write random data back. Signed-off-by: Russell King --- arch/arm/lib/bitops.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/lib/bitops.h b/arch/arm/lib/bitops.h index 6976e60e47cb..5382a3023602 100644 --- a/arch/arm/lib/bitops.h +++ b/arch/arm/lib/bitops.h @@ -19,9 +19,9 @@ mov r3, r2, lsl r3 @ create mask 1: ldrexb r2, [r1] ands r0, r2, r3 @ save old value of bit - \instr ip, r2, r3 @ toggle bit - strexb r2, ip, [r1] - cmp r2, #0 + \instr r2, r2, r3 @ toggle bit + strexb ip, r2, [r1] + cmp ip, #0 bne 1b cmp r0, #0 movne r0, #1 -- 2.39.5