From 692d79e179f9a6c02de316a37c652939e7761d38 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Kristina=20Mart=C5=A1enko?= Date: Mon, 3 Mar 2014 23:05:42 +0200 Subject: [PATCH] staging: sbe-2t3e3: remove t3e3_rx_desc_t typedef MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Kernel coding style does not recommend using typedefs for structures, so remove the t3e3_rx_desc_t typedef. Fix the following checkpatch warning: drivers/staging/sbe-2t3e3/2t3e3.h:616: WARNING: do not add new typedefs Signed-off-by: Kristina Martšenko Signed-off-by: Greg Kroah-Hartman --- drivers/staging/sbe-2t3e3/2t3e3.h | 6 +++--- drivers/staging/sbe-2t3e3/dc.c | 2 +- drivers/staging/sbe-2t3e3/intr.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/sbe-2t3e3/2t3e3.h b/drivers/staging/sbe-2t3e3/2t3e3.h index a799975efd3f..3577fad61c5e 100644 --- a/drivers/staging/sbe-2t3e3/2t3e3.h +++ b/drivers/staging/sbe-2t3e3/2t3e3.h @@ -613,12 +613,12 @@ * descriptor list and data buffer * **********************************************************************/ -typedef struct { +struct t3e3_rx_desc { u32 rdes0; u32 rdes1; u32 rdes2; u32 rdes3; -} t3e3_rx_desc_t; +}; #define SBE_2T3E3_RX_DESC_RING_SIZE 64 @@ -723,7 +723,7 @@ struct channel { u32 interrupt_enable_mask; /* receive chain/ring */ - t3e3_rx_desc_t *rx_ring; + struct t3e3_rx_desc *rx_ring; struct sk_buff *rx_data[SBE_2T3E3_RX_DESC_RING_SIZE]; u32 rx_ring_current_read; diff --git a/drivers/staging/sbe-2t3e3/dc.c b/drivers/staging/sbe-2t3e3/dc.c index 42ae67c5bc33..0d60bc77f91a 100644 --- a/drivers/staging/sbe-2t3e3/dc.c +++ b/drivers/staging/sbe-2t3e3/dc.c @@ -316,7 +316,7 @@ static int dc_init_descriptor_list(struct channel *sc) if (sc->ether.rx_ring == NULL) sc->ether.rx_ring = kcalloc(SBE_2T3E3_RX_DESC_RING_SIZE, - sizeof(t3e3_rx_desc_t), GFP_KERNEL); + sizeof(struct t3e3_rx_desc), GFP_KERNEL); if (sc->ether.rx_ring == NULL) return -ENOMEM; diff --git a/drivers/staging/sbe-2t3e3/intr.c b/drivers/staging/sbe-2t3e3/intr.c index efdeb7510047..a346c516bcc3 100644 --- a/drivers/staging/sbe-2t3e3/intr.c +++ b/drivers/staging/sbe-2t3e3/intr.c @@ -118,7 +118,7 @@ void dc_intr_rx(struct channel *sc) { u32 current_read; u32 error_mask, error; - t3e3_rx_desc_t *current_desc; + struct t3e3_rx_desc *current_desc; struct sk_buff *m, *m2; unsigned rcv_len; -- 2.39.2