From 6e958051cb0742dd54bb61528c130bd6eaecae0d Mon Sep 17 00:00:00 2001 From: Wei Yongjun Date: Fri, 12 Aug 2016 11:22:22 +0000 Subject: [PATCH] usbip: vhci_hcd: fix return value check in add_platform_device() In case of error, the function platform_device_register_simple() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun Signed-off-by: Greg Kroah-Hartman --- drivers/usb/usbip/vhci_hcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c index 96f2dacb27fa..03eccf29ace0 100644 --- a/drivers/usb/usbip/vhci_hcd.c +++ b/drivers/usb/usbip/vhci_hcd.c @@ -1211,8 +1211,8 @@ static int add_platform_device(int id) dev_nr = id; pdev = platform_device_register_simple(driver_name, dev_nr, NULL, 0); - if (pdev == NULL) - return -ENODEV; + if (IS_ERR(pdev)) + return PTR_ERR(pdev); *(vhci_pdevs + id) = pdev; return 0; -- 2.39.5