From 6fa1adbcdd28f27b639954e5bb202a2de281679a Mon Sep 17 00:00:00 2001 From: Viresh Kumar Date: Fri, 3 Jul 2015 17:00:25 +0530 Subject: [PATCH] greybus: connection: Exit connection before destroying it gb_connection_create() can initialize a connection if bundle->device id is valid. And so the connection must be destroyed by calling gb_connection_exit() before gb_connection_destroy(). This wasn't done in the code that is parsing the manifest. Fix it. Signed-off-by: Viresh Kumar Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/manifest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/greybus/manifest.c b/drivers/staging/greybus/manifest.c index ce4e89c6d13e..bea565f1c1d1 100644 --- a/drivers/staging/greybus/manifest.c +++ b/drivers/staging/greybus/manifest.c @@ -255,6 +255,7 @@ cleanup: /* An error occurred; undo any changes we've made */ list_for_each_entry_safe(connection, connection_next, &bundle->connections, bundle_links) { + gb_connection_exit(connection); gb_connection_destroy(connection); count--; } -- 2.39.2