From 765a75b34a9d72aca875d85d4dc40945afd2939e Mon Sep 17 00:00:00 2001 From: Martin Brandenburg Date: Tue, 15 Dec 2015 14:48:17 -0500 Subject: [PATCH] orangefs: Remove useless inline qualifier from bufmap functions. All callers were outside of the file these functions were declared in, so nothing was ever inlined anyway. Further this happens before I/O and any speedup by not having to do a call will be dwarfed by the time it takes to talk to the server. Signed-off-by: Mike Marshall Signed-off-by: Martin Brandenburg --- fs/orangefs/orangefs-bufmap.c | 4 ++-- fs/orangefs/orangefs-bufmap.h | 4 ---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/fs/orangefs/orangefs-bufmap.c b/fs/orangefs/orangefs-bufmap.c index bf8470060c74..cf3ffb57334b 100644 --- a/fs/orangefs/orangefs-bufmap.c +++ b/fs/orangefs/orangefs-bufmap.c @@ -82,7 +82,7 @@ static void orangefs_bufmap_unref(struct orangefs_bufmap *bufmap) } } -inline int orangefs_bufmap_size_query(void) +int orangefs_bufmap_size_query(void) { struct orangefs_bufmap *bufmap = orangefs_bufmap_ref(); int size = bufmap ? bufmap->desc_size : 0; @@ -91,7 +91,7 @@ inline int orangefs_bufmap_size_query(void) return size; } -inline int orangefs_bufmap_shift_query(void) +int orangefs_bufmap_shift_query(void) { struct orangefs_bufmap *bufmap = orangefs_bufmap_ref(); int shift = bufmap ? bufmap->desc_shift : 0; diff --git a/fs/orangefs/orangefs-bufmap.h b/fs/orangefs/orangefs-bufmap.h index f652b464b340..112ec33a1b86 100644 --- a/fs/orangefs/orangefs-bufmap.h +++ b/fs/orangefs/orangefs-bufmap.h @@ -9,10 +9,6 @@ struct orangefs_bufmap; -/* - * orangefs_bufmap_size_query is now an inline function because buffer - * sizes are not hardcoded - */ int orangefs_bufmap_size_query(void); int orangefs_bufmap_shift_query(void); -- 2.39.5