From 80868c8e5c04bb725e411b078881b65ebbecd142 Mon Sep 17 00:00:00 2001 From: David Howells Date: Thu, 2 Apr 2015 08:03:11 -0300 Subject: [PATCH] [media] ts2020: Add a comment about lifetime of on-stack pdata in ts2020_attach() ts2020_attach() allocates a variable pdata on the stack and then passes a pointer to it to i2c_new_device() which stashes the pointer in persistent structures. Add a comment to the effect that this isn't actually an error because the contents of the variable are only used in ts2020_probe() and this is only called ts2020_attach()'s stack frame exists. Signed-off-by: David Howells Signed-off-by: Antti Palosaari Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/ts2020.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/dvb-frontends/ts2020.c b/drivers/media/dvb-frontends/ts2020.c index 797112bbbaa8..f674717fa921 100644 --- a/drivers/media/dvb-frontends/ts2020.c +++ b/drivers/media/dvb-frontends/ts2020.c @@ -363,6 +363,8 @@ struct dvb_frontend *ts2020_attach(struct dvb_frontend *fe, { struct i2c_client *client; struct i2c_board_info board_info; + + /* This is only used by ts2020_probe() so can be on the stack */ struct ts2020_config pdata; memcpy(&pdata, config, sizeof(pdata)); -- 2.39.2