From 962e5a36c718678b89939a217eb527c56d9ee8a0 Mon Sep 17 00:00:00 2001 From: H Hartley Sweeten Date: Tue, 9 Apr 2013 16:30:48 -0700 Subject: [PATCH] staging: comedi: das16: use __comedi_request_region() Use __comedi_request_region() to request the additional I/O region used by this driver. Remove the error message when the request_region() fails, comedi_request_reqion() will output the error message if necessary. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman Signed-off-by: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/comedi/drivers/das16.c b/drivers/staging/comedi/drivers/das16.c index 01fe078f3914..50902ccb5193 100644 --- a/drivers/staging/comedi/drivers/das16.c +++ b/drivers/staging/comedi/drivers/das16.c @@ -1120,13 +1120,10 @@ static int das16_attach(struct comedi_device *dev, struct comedi_devconfig *it) if (ret) return ret; /* Request an additional region for the 8255 */ - if (!request_region(dev->iobase + 0x400, board->size & 0x3ff, - dev->board_name)) { + ret = __comedi_request_region(dev, dev->iobase + 0x400, + board->size & 0x3ff); + if (ret) { release_region(dev->iobase, 0x10); - dev_warn(dev->class_dev, - "%s: I/O port conflict (%#lx,%d)\n", - dev->board_name, - dev->iobase + 0x400, board->size & 0x3ff); dev->iobase = 0; return -EIO; } -- 2.39.5