From 966630bc79fd16df43e4dc172771371f59d94849 Mon Sep 17 00:00:00 2001 From: Mark Einon Date: Wed, 11 Sep 2013 14:14:46 +0100 Subject: [PATCH] staging: et131x: Add some items to the TODO list Adding some trivial formatting suggestions made by Dan Carpenter to the TODO. Signed-off-by: Mark Einon Signed-off-by: Greg Kroah-Hartman --- drivers/staging/et131x/README | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README index 9272a24ae61c..8da96a6d2c92 100644 --- a/drivers/staging/et131x/README +++ b/drivers/staging/et131x/README @@ -11,7 +11,12 @@ TODO: - Look at reducing the number of spinlocks - Simplify code in nic_rx_pkts(), when determining multicast_pkts_rcvd - Implement NAPI support - - in et131x_tx(), don't return NETDEV_TX_BUSY, just drop the packet with kfree_skb(). + - In et131x_tx(), don't return NETDEV_TX_BUSY, just drop the packet with kfree_skb(). + - Reduce the number of split lines by careful consideration of variable names etc. + - Do this in et131x.c: + struct fbr_lookup *fbr; + fbr = rx_local->fbr[id]; + Then replace all the instances of "rx_local->fbr[id]" with fbr. Please send patches to: Greg Kroah-Hartman -- 2.39.5