From 9768d378c6ef038515d1111592f1ce8d91dbc40b Mon Sep 17 00:00:00 2001 From: Sasikantha babu Date: Wed, 25 Apr 2012 11:03:41 +1000 Subject: [PATCH] mm/vmstat.c: remov debug fs entries on failure of file creation and made extfrag_debug_root dentry local Removed debug fs files and directory on failure. Since no one using "extfrag_debug_root" dentry outside of function extfrag_debug_init made it local to the function. Signed-off-by: Sasikantha babu Acked-by: David Rientjes Acked-by: Mel Gorman Signed-off-by: Andrew Morton --- mm/vmstat.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/mm/vmstat.c b/mm/vmstat.c index 0dad31dc1618..1bbbbd9776ad 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -1223,7 +1223,6 @@ module_init(setup_vmstat) #if defined(CONFIG_DEBUG_FS) && defined(CONFIG_COMPACTION) #include -static struct dentry *extfrag_debug_root; /* * Return an index indicating how much of the available free memory is @@ -1361,19 +1360,24 @@ static const struct file_operations extfrag_file_ops = { static int __init extfrag_debug_init(void) { + struct dentry *extfrag_debug_root; + extfrag_debug_root = debugfs_create_dir("extfrag", NULL); if (!extfrag_debug_root) return -ENOMEM; if (!debugfs_create_file("unusable_index", 0444, extfrag_debug_root, NULL, &unusable_file_ops)) - return -ENOMEM; + goto fail; if (!debugfs_create_file("extfrag_index", 0444, extfrag_debug_root, NULL, &extfrag_file_ops)) - return -ENOMEM; + goto fail; return 0; +fail: + debugfs_remove_recursive(extfrag_debug_root); + return -ENOMEM; } module_init(extfrag_debug_init); -- 2.39.5