From a197a191f73a75d80d5b67e09e0b89c214dc3690 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Uwe=20Kleine-K=C3=B6nig?= Date: Wed, 14 Dec 2011 21:26:51 +0100 Subject: [PATCH] serial/imx: propagate error from of_alias_get_id instead of using -ENODEV MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit A quick look at of_alias_get_id shows that in the error case it returns -ENODEV, too, but still it's better style to propagate the value as is. Signed-off-by: Uwe Kleine-König Cc: Shawn Guo Cc: Alan Cox Cc: Grant Likely Cc: Jeremy Kerr Cc: Jason Liu Cc: Sascha Hauer Acked-by: Jason Liu Signed-off-by: Shawn Guo Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index ed6e1448e7eb..2813f0210377 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -1316,7 +1316,7 @@ static int serial_imx_probe_dt(struct imx_port *sport, ret = of_alias_get_id(np, "serial"); if (ret < 0) { dev_err(&pdev->dev, "failed to get alias id, errno %d\n", ret); - return -ENODEV; + return ret; } sport->port.line = ret; -- 2.39.2