From a3d5476c9ad7f3c7df0653de9461992209283b06 Mon Sep 17 00:00:00 2001 From: Theodore Ts'o Date: Thu, 6 Jun 2013 11:16:43 -0400 Subject: [PATCH] ext4: add sanity check to ext4_get_group_info() The group number passed to ext4_get_group_info() should be valid, but let's add an assert to check this before we start creating a pointer based on that group number and dereferencing it. Signed-off-by: "Theodore Ts'o" --- fs/ext4/ext4.h | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index bd9890f6d9ce..f85f1fb49df8 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h @@ -2313,6 +2313,7 @@ struct ext4_group_info *ext4_get_group_info(struct super_block *sb, { struct ext4_group_info ***grp_info; long indexv, indexh; + BUG_ON(group >= EXT4_SB(sb)->s_groups_count); grp_info = EXT4_SB(sb)->s_group_info; indexv = group >> (EXT4_DESC_PER_BLOCK_BITS(sb)); indexh = group & ((EXT4_DESC_PER_BLOCK(sb)) - 1); -- 2.39.5