From a3dd01e17756e85badd587de774cec783abe1b19 Mon Sep 17 00:00:00 2001 From: Rickard Strandqvist Date: Sat, 28 Jun 2014 23:34:38 +0200 Subject: [PATCH] mfd: ab8500-debugfs: Cleaning up unnecessary to test, unsigned can't be negative. Unsigned variable can't be negative so it is unnecessary to test it This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist Signed-off-by: Lee Jones --- drivers/mfd/ab8500-debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c index 8452c15bf4d4..e23fcbad79d6 100644 --- a/drivers/mfd/ab8500-debugfs.c +++ b/drivers/mfd/ab8500-debugfs.c @@ -2503,7 +2503,7 @@ static ssize_t ab8500_gpadc_trig_timer_write(struct file *file, if (err) return err; - if ((user_trig_timer >= 0) && (user_trig_timer <= 255)) { + if (user_trig_timer <= 255) { trig_timer = (u8) user_trig_timer; } else { dev_err(dev, "debugfs error input: " -- 2.39.2