From a4bc746c41b56ab7588b20d84a58906986edce83 Mon Sep 17 00:00:00 2001 From: kbuild test robot Date: Tue, 20 Sep 2016 08:10:13 +0800 Subject: [PATCH] ALSA: line6: fix ifnullfree.cocci warnings sound/usb/line6/driver.c:484:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci CC: Andrej Krutak Signed-off-by: Fengguang Wu Signed-off-by: Takashi Iwai --- sound/usb/line6/driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/usb/line6/driver.c b/sound/usb/line6/driver.c index f9224ec141c8..c998667e98ef 100644 --- a/sound/usb/line6/driver.c +++ b/sound/usb/line6/driver.c @@ -480,8 +480,7 @@ static void line6_destruct(struct snd_card *card) /* Free buffer memory first. We cannot depend on the existence of private * data from the (podhd) module, it may be gone already during this call */ - if (line6->buffer_message) - kfree(line6->buffer_message); + kfree(line6->buffer_message); kfree(line6->buffer_listen); -- 2.39.5