From a64dcde9c074fc385fe6d4d2aa26a4fbae10ac20 Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Thu, 17 Nov 2011 10:41:27 +1100 Subject: [PATCH] mm-reduce-the-amount-of-work-done-when-updating-min_free_kbytes-checkpatch-fixes Cc: Mel Gorman WARNING: line over 80 characters #42: FILE: mm/page_alloc.c:3464: + /* Blocks with reserved pages will never free, skip them. */ WARNING: line over 80 characters #61: FILE: mm/page_alloc.c:3477: + set_pageblock_migratetype(page, MIGRATE_RESERVE); WARNING: line over 80 characters #62: FILE: mm/page_alloc.c:3478: + move_freepages_block(zone, page, MIGRATE_RESERVE); total: 0 errors, 3 warnings, 44 lines checked ./patches/mm-reduce-the-amount-of-work-done-when-updating-min_free_kbytes.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Mel Gorman Signed-off-by: Andrew Morton --- mm/page_alloc.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 5ac72794e403..8e11ff21014a 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -3451,7 +3451,10 @@ static void setup_zone_migrate_reserve(struct zone *zone) /* Only test what is necessary when the reserves are not met */ if (reserve > 0) { - /* Blocks with reserved pages will never free, skip them. */ + /* + * Blocks with reserved pages will never free, skip + * them. + */ block_end_pfn = min(pfn + pageblock_nr_pages, end_pfn); if (pageblock_is_reserved(pfn, block_end_pfn)) continue; @@ -3464,8 +3467,10 @@ static void setup_zone_migrate_reserve(struct zone *zone) /* Suitable for reserving if this block is movable */ if (block_migratetype == MIGRATE_MOVABLE) { - set_pageblock_migratetype(page, MIGRATE_RESERVE); - move_freepages_block(zone, page, MIGRATE_RESERVE); + set_pageblock_migratetype(page, + MIGRATE_RESERVE); + move_freepages_block(zone, page, + MIGRATE_RESERVE); reserve--; continue; } -- 2.39.5