From abb722e79a07b0a438a3782fd3f7d8c85f541d5f Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Wed, 1 Jul 2015 12:37:24 +0200 Subject: [PATCH] greybus: operation: make response helper static Since commit 46ce118a2678 ("operation: refactor response handling") sending operation responses is handled by greybus core so there is currently no need to export the response helper. Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/operation.c | 7 +++++-- drivers/staging/greybus/operation.h | 1 - 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/operation.c b/drivers/staging/greybus/operation.c index eee315c5861d..3392b425a6c2 100644 --- a/drivers/staging/greybus/operation.c +++ b/drivers/staging/greybus/operation.c @@ -29,6 +29,9 @@ static struct workqueue_struct *gb_operation_workqueue; */ static DEFINE_SPINLOCK(gb_operations_lock); +static int gb_operation_response_send(struct gb_operation *operation, + int errno); + /* * Set an operation's result. * @@ -649,7 +652,8 @@ EXPORT_SYMBOL_GPL(gb_operation_request_send_sync); * it can simply supply the result errno; this function will * allocate the response message if necessary. */ -int gb_operation_response_send(struct gb_operation *operation, int errno) +static int gb_operation_response_send(struct gb_operation *operation, + int errno) { struct gb_connection *connection = operation->connection; int ret; @@ -685,7 +689,6 @@ int gb_operation_response_send(struct gb_operation *operation, int errno) return ret; } -EXPORT_SYMBOL_GPL(gb_operation_response_send); /* * This function is called when a message send request has completed. diff --git a/drivers/staging/greybus/operation.h b/drivers/staging/greybus/operation.h index 40632238845e..3bf757195fa3 100644 --- a/drivers/staging/greybus/operation.h +++ b/drivers/staging/greybus/operation.h @@ -150,7 +150,6 @@ int gb_operation_request_send(struct gb_operation *operation, gb_operation_callback callback, gfp_t gfp); int gb_operation_request_send_sync(struct gb_operation *operation); -int gb_operation_response_send(struct gb_operation *operation, int errno); void gb_operation_cancel(struct gb_operation *operation, int errno); -- 2.39.5