From bbbdc23e30b813d90d1cc9dd5caaaaf5e35b6878 Mon Sep 17 00:00:00 2001 From: Eva Rachel Retuya Date: Wed, 2 Mar 2016 22:23:46 +0800 Subject: [PATCH] staging: gs_fpgaboot: drop wrapper function 'finish_driver' Remove the function 'finish_driver' since a direct call to platform_device_unregister() is intuitive enough to signify the original intention of the function being removed. Coccinelle semantic patch used to detect this: @@ identifier wrapper, func; type T; @@ *T wrapper(...) { ( return func(...); | func(...); ) } Signed-off-by: Eva Rachel Retuya Signed-off-by: Greg Kroah-Hartman --- drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c index fe3a6bc19eed..7b7c9786c162 100644 --- a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c +++ b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c @@ -281,11 +281,6 @@ static int init_driver(void) return PTR_ERR_OR_ZERO(firmware_pdev); } -static void finish_driver(void) -{ - platform_device_unregister(firmware_pdev); -} - static int gs_fpgaboot(void) { int err; @@ -370,14 +365,14 @@ static int __init gs_fpgaboot_init(void) return 0; errout: - finish_driver(); + platform_device_unregister(firmware_pdev); return err; } static void __exit gs_fpgaboot_exit(void) { - finish_driver(); + platform_device_unregister(firmware_pdev); pr_info("FPGA image download module removed\n"); } -- 2.39.2