From c3f0da631539b3b8e17f6dda567af9958d49d14f Mon Sep 17 00:00:00 2001 From: Bob Liu Date: Thu, 13 Jan 2011 15:45:49 -0800 Subject: [PATCH] mm/page-writeback.c: fix __set_page_dirty_no_writeback() return value __set_page_dirty_no_writeback() should return true if it actually transitioned the page from a clean to dirty state although it seems nobody uses its return value at present. Signed-off-by: Bob Liu Acked-by: Wu Fengguang Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- mm/page-writeback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page-writeback.c b/mm/page-writeback.c index b5d8a1f820a0..28763b8bdbdd 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -1103,7 +1103,7 @@ EXPORT_SYMBOL(write_one_page); int __set_page_dirty_no_writeback(struct page *page) { if (!PageDirty(page)) - SetPageDirty(page); + return !TestSetPageDirty(page); return 0; } -- 2.39.5