From c8e7fd2807c76ec171fee6bce142cd06b5745497 Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Sat, 7 Feb 2009 18:15:56 +1030 Subject: [PATCH] module: remove over-zealous check in __module_get() commit 7f9a50a5b89b87f8e754f59ae9968da28be618a5 upstream. Impact: fix spurious BUG_ON() triggered under load module_refcount() isn't reliable outside stop_machine(), as demonstrated by Karsten Keil , networking can trigger it under load (an inc on one cpu and dec on another while module_refcount() is tallying can give false results, for example). Almost noone should be using __module_get, but that's another issue. Cc: Karsten Keil Signed-off-by: Rusty Russell Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- include/linux/module.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/module.h b/include/linux/module.h index 68e09557c951..760a41bf88e4 100644 --- a/include/linux/module.h +++ b/include/linux/module.h @@ -387,7 +387,6 @@ void symbol_put_addr(void *addr); static inline void __module_get(struct module *module) { if (module) { - BUG_ON(module_refcount(module) == 0); local_inc(&module->ref[get_cpu()].count); put_cpu(); } -- 2.39.2