From cdfaf50b1caa722e805308efa2603ccdcc4abd5d Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Thu, 25 Oct 2012 12:15:13 +1100 Subject: [PATCH] hfsplus-add-support-of-manipulation-by-attributes-file-checkpatch-fixes WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... #280: FILE: fs/hfsplus/btree.c:103: + printk(KERN_ERR "hfs: invalid attributes max_key_len %d\n", WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... #589: FILE: fs/hfsplus/inode.c:353: + printk(KERN_ERR "hfs: sync non-existent attributes tree\n"); WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... #643: FILE: fs/hfsplus/super.c:482: + printk(KERN_ERR "hfs: failed to load attributes file\n"); ERROR: code indent should use tabs where possible #686: FILE: fs/hfsplus/super.c:660: + ^Ireturn err;$ WARNING: please, no space before tabs #686: FILE: fs/hfsplus/super.c:660: + ^Ireturn err;$ WARNING: please, no spaces at the start of a line #686: FILE: fs/hfsplus/super.c:660: + ^Ireturn err;$ total: 1 errors, 5 warnings, 616 lines checked NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or scripts/cleanfile ./patches/hfsplus-add-support-of-manipulation-by-attributes-file.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Vyacheslav Dubeyko Signed-off-by: Andrew Morton --- fs/hfsplus/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c index d7d54cf6c98e..fec2151784ee 100644 --- a/fs/hfsplus/super.c +++ b/fs/hfsplus/super.c @@ -657,7 +657,7 @@ destroy_attr_tree_cache: destroy_inode_cache: kmem_cache_destroy(hfsplus_inode_cachep); - return err; + return err; } static void __exit exit_hfsplus_fs(void) -- 2.39.5