From d69d4d2e3dfdf68dbd27994baf872bbc5d67ad96 Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Thu, 25 Oct 2012 12:15:09 +1100 Subject: [PATCH] binfmt_elf-fix-corner-case-kfree-of-uninitialized-data-checkpatch-fixes WARNING: line over 80 characters #24: FILE: fs/binfmt_elf.c:1604: + info->psinfo.data = NULL; /* So we don't free this wrongly */ ERROR: code indent should use tabs where possible #26: FILE: fs/binfmt_elf.c:1606: + }$ WARNING: please, no spaces at the start of a line #26: FILE: fs/binfmt_elf.c:1606: + }$ total: 1 errors, 2 warnings, 11 lines checked NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or scripts/cleanfile ./patches/binfmt_elf-fix-corner-case-kfree-of-uninitialized-data.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Alan Cox Signed-off-by: Andrew Morton --- fs/binfmt_elf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index 5c0721863897..ea35e7ab9b1b 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -1601,9 +1601,9 @@ static int fill_note_info(struct elfhdr *elf, int phdrs, psinfo = kmalloc(sizeof(*psinfo), GFP_KERNEL); if (psinfo == NULL) { - info->psinfo.data = NULL; /* So we don't free this wrongly */ + info->psinfo.data = NULL; /* So we don't free this wrongly */ return 0; - } + } fill_note(&info->psinfo, "CORE", NT_PRPSINFO, sizeof(*psinfo), psinfo); -- 2.39.5