From d6e29ca1f6cf566f67012dce269b5f9ba72a1659 Mon Sep 17 00:00:00 2001 From: Amitoj Kaur Chawla Date: Wed, 24 Feb 2016 20:54:28 +0530 Subject: [PATCH] staging: speakup: Remove unnecessary test in if condition Remove unnecessary test on synth->alive since it has already been tested previously. This fixes the following smatch warning: drivers/staging/speakup/synth.c:182 spk_synth_is_alive_restart() warn: we tested 'synth->alive' before and it was 'false' Signed-off-by: Amitoj Kaur Chawla Signed-off-by: Greg Kroah-Hartman --- drivers/staging/speakup/synth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c index 01eddab93c66..4f462c35fdd9 100644 --- a/drivers/staging/speakup/synth.c +++ b/drivers/staging/speakup/synth.c @@ -179,7 +179,7 @@ int spk_synth_is_alive_restart(struct spk_synth *synth) { if (synth->alive) return 1; - if (!synth->alive && spk_wait_for_xmitr() > 0) { + if (spk_wait_for_xmitr() > 0) { /* restart */ synth->alive = 1; synth_printf("%s", synth->init); -- 2.39.5