From e134201b7a27eaf1ce3affe39ea6f30a1a747186 Mon Sep 17 00:00:00 2001 From: Sudip Mukherjee Date: Mon, 9 Mar 2015 20:08:24 +0530 Subject: [PATCH] staging: panel: return register value we were returning success even if the module failed to register. now we are returning the actual return value, success or error. Signed-off-by: Sudip Mukherjee Acked-by: Willy Tarreau Signed-off-by: Greg Kroah-Hartman --- drivers/staging/panel/panel.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c index ac147253cc54..ee26413cea47 100644 --- a/drivers/staging/panel/panel.c +++ b/drivers/staging/panel/panel.c @@ -2282,7 +2282,7 @@ static struct parport_driver panel_driver = { /* init function */ static int __init panel_init_module(void) { - int selected_keypad_type = NOT_SET; + int selected_keypad_type = NOT_SET, err; /* take care of an eventual profile */ switch (profile) { @@ -2388,9 +2388,10 @@ static int __init panel_init_module(void) return -ENODEV; } - if (parport_register_driver(&panel_driver)) { + err = parport_register_driver(&panel_driver); + if (err) { pr_err("could not register with parport. Aborting.\n"); - return -EIO; + return err; } if (pprt) -- 2.39.2