From e49af8449f7202eef1b9b889b2f98ab067729784 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Wed, 8 Apr 2015 09:43:56 +1000 Subject: [PATCH] ocfs2: double evaluation concerns in mlog_errno() It won't happen in real life, but for consistency etc then we should only evaluate the "st" parameter once. Also, since not all callers use the new return, it causes at static checker warning: fs/ocfs2/export.c:138 ocfs2_get_dentry() warn: unchecked 'PTR_ERR' Signed-off-by: Dan Carpenter Cc: Mark Fasheh Cc: Joel Becker Cc: alex chen Signed-off-by: Andrew Morton --- fs/ocfs2/cluster/masklog.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ocfs2/cluster/masklog.h b/fs/ocfs2/cluster/masklog.h index f96a51dd4be8..7fdc25a4d8c0 100644 --- a/fs/ocfs2/cluster/masklog.h +++ b/fs/ocfs2/cluster/masklog.h @@ -202,7 +202,7 @@ extern struct mlog_bits mlog_and_bits, mlog_not_bits; _st != AOP_TRUNCATED_PAGE && _st != -ENOSPC && \ _st != -EDQUOT) \ mlog(ML_ERROR, "status = %lld\n", (long long)_st); \ - st; \ + _st; \ }) #define mlog_bug_on_msg(cond, fmt, args...) do { \ -- 2.39.5