From e66466ab9fe6aea1f88a6e5f9cb82bd3eab2e463 Mon Sep 17 00:00:00 2001 From: Dmitry Kasatkin Date: Fri, 12 Oct 2012 15:22:54 +1100 Subject: [PATCH] vfs: increment iversion when a file is truncated When a file is truncated with truncate()/ftruncate() and then closed, iversion is not updated. This patch uses ATTR_SIZE flag as an indication to increment iversion. Mimi said: On fput(), i_version is used to detect and flag files that have changed and need to be re-measured in the IMA measurement policy. When a file is truncated with truncate()/ftruncate() and then closed, i_version is not updated. As a result, although the file has changed, it will not be re-measured and added to the IMA measurement list on subsequent access. Signed-off-by: Dmitry Kasatkin Acked-by: Mimi Zohar Cc: Al Viro Cc: Signed-off-by: Andrew Morton --- fs/attr.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/fs/attr.c b/fs/attr.c index cce7df53b694..9689817dd26a 100644 --- a/fs/attr.c +++ b/fs/attr.c @@ -184,6 +184,11 @@ int notify_change(struct dentry * dentry, struct iattr * attr) inode_inc_iversion(inode); } + if ((ia_valid & ATTR_SIZE) && IS_I_VERSION(inode)) { + if (attr->ia_size != inode->i_size) + inode_inc_iversion(inode); + } + if ((ia_valid & ATTR_MODE)) { umode_t amode = attr->ia_mode; /* Flag setting protected by i_mutex */ -- 2.39.2