From e8cd29d8e26b9f7526297cdfb031ce757502a3b4 Mon Sep 17 00:00:00 2001 From: Natalia Ovsyanikov Date: Mon, 5 Dec 2011 00:16:54 +0200 Subject: [PATCH] staging/mei: fix failure for multiple mei clients connection The irq handler processes queued mei clients connect requests, which were not transferred to the device in ioctl context due to unavailability of the write buffer. The handler may transfer the connection request only if there is no other ongoing requests for the same mei id. This condition was implemented inversely which depending on the write buffer availability lead to seemingly random failures during connection attempts. Cc: Oren Weil Signed-off-by: Natalia Ovsyanikov Signed-off-by: Tomas Winkler Signed-off-by: Greg Kroah-Hartman --- drivers/staging/mei/interrupt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/mei/interrupt.c b/drivers/staging/mei/interrupt.c index 38e0197475e..ad944b2c1da 100644 --- a/drivers/staging/mei/interrupt.c +++ b/drivers/staging/mei/interrupt.c @@ -1328,7 +1328,7 @@ static int mei_irq_thread_write_handler(struct mei_io_list *cmpl_list, break; case MEI_IOCTL: /* connect message */ - if (!mei_other_client_is_connecting(dev, cl)) + if (mei_other_client_is_connecting(dev, cl)) continue; ret = _mei_irq_thread_ioctl(dev, slots, pos, cl, cmpl_list); if (ret) -- 2.39.5