From f9fdf12742cdc18ca30ff6c3bec3bf1748deffa7 Mon Sep 17 00:00:00 2001 From: Li Zefan Date: Wed, 16 Jan 2008 01:18:12 +0200 Subject: [PATCH] CONNECTOR: don't touch queue dev after decrement of ref count cn_queue_free_callback() will touch 'dev'(i.e. cbq->pdev), so it should be called before atomic_dec(&dev->refcnt). Signed-off-by: Li Zefan Signed-off-by: Adrian Bunk --- drivers/connector/cn_queue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/connector/cn_queue.c b/drivers/connector/cn_queue.c index 9f2f00d82917..e9de8a79acaa 100644 --- a/drivers/connector/cn_queue.c +++ b/drivers/connector/cn_queue.c @@ -98,8 +98,8 @@ int cn_queue_add_callback(struct cn_queue_dev *dev, char *name, struct cb_id *id spin_unlock_bh(&dev->queue_lock); if (found) { - atomic_dec(&dev->refcnt); cn_queue_free_callback(cbq); + atomic_dec(&dev->refcnt); return -EINVAL; } -- 2.39.5