From fb0cb24a004ac4015ecd1ad7d279830dcec55e60 Mon Sep 17 00:00:00 2001 From: Ed Cashin Date: Thu, 29 Nov 2012 14:19:07 +1100 Subject: [PATCH] aoe: manipulate aoedev network stats under lock With this bugfix in place the calculation of the criterion for "lateness" is performed under lock. Without the lock, there is a chance that one of the non-atomic operations performed on the round trip time statistics could be incomplete, such that an incorrect lateness criterion would be calculated. Without this change, the effect of the bug would be rare unecessary but benign retransmissions. Signed-off-by: Ed Cashin Signed-off-by: Andrew Morton --- drivers/block/aoe/aoecmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c index 6ea27fd8954d..9aefbe3957ca 100644 --- a/drivers/block/aoe/aoecmd.c +++ b/drivers/block/aoe/aoecmd.c @@ -603,14 +603,14 @@ rexmit_timer(ulong vp) d = (struct aoedev *) vp; + spin_lock_irqsave(&d->lock, flags); + /* timeout based on observed timings and variations */ timeout = 2 * d->rttavg >> RTTSCALE; timeout += 8 * d->rttdev >> RTTDSCALE; if (timeout == 0) timeout = 1; - spin_lock_irqsave(&d->lock, flags); - if (d->flags & DEVFL_TKILL) { spin_unlock_irqrestore(&d->lock, flags); return; -- 2.39.5